Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settlements endpoint return received as null #1212

Closed
agazso opened this issue Feb 8, 2021 · 1 comment
Closed

Settlements endpoint return received as null #1212

agazso opened this issue Feb 8, 2021 · 1 comment
Labels
bug Something isn't working issue

Comments

@agazso
Copy link
Member

agazso commented Feb 8, 2021

Summary

When calling the /settlements/{peer} endpoint it may return the received as null, but in the OpenAPI definition it is number.

bee/openapi/SwarmCommon.yaml

Line 284 in 67ff6fb

received:

This worked last Friday, so something since then broke it. This commit is suspicious:
273f120
@agazso agazso added the bug Something isn't working label Feb 8, 2021
@bee-runner bee-runner bot added the issue label Feb 8, 2021
agazso added a commit to ethersphere/bee-js that referenced this issue Feb 8, 2021
@agazso
fix: workaround for settlements bug
072f4ce 
ethersphere/bee#1212
@acud acud mentioned this issue Feb 8, 2021
Merged
@agazso
Copy link
Member Author

agazso commented Feb 8, 2021

Fixed by #1213

@agazso agazso closed this as completed Feb 8, 2021
agazso added a commit to ethersphere/bee-js that referenced this issue Feb 9, 2021
@agazso
refactor!: breaking api changes (#105)
5eb1d15 
* refactor: breaking api changes

* refactor: add owner to SOC interface

* feat: add /soc endpoint module

* fix: soc owner calculation

* chore: fix linter issues

* fix: add ReferenceResponse to types

* fix: comment out beeinfra version change

* chore: cleanup

* docs: add comment to CI script

* fix: workaround for settlements bug

ethersphere/bee#1212

* refactor: requested changes

* fix: settlements bug

* test: change ci to run Bee 0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agazso