Adding file upload handler #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aloknerurkar
commented
Apr 2, 2021
aloknerurkar
commented
- Adding new file upload handler (POST /bzz)
- all unit tests passing
aloknerurkar
commented
Apr 2, 2021
| @@ -16,6 +16,14 @@ import ( | |||
|
|
|||
| const DefaultManifestType = ManifestMantarayContentType | |||
|
|
|||
| const ( | |||
| RootPath = "/" | |||
There was a problem hiding this comment.
@acud
The reason I moved these here is because I need them in the traversal tests. The traversal package doesn't need this. I don't see any particular reason why any package apart from api would need this.
api package imports traversal, so I cannot import api in traversal pkg. Also if these change in future, the traversal tests need to change. So maybe enough reason to move these here? That way both packages can access these as they both depend on manifest
acud
reviewed
Apr 2, 2021
aloknerurkar
changed the title
aloknerurkar
added a commit
that referenced
this pull request
Apr 9, 2021
File upload handler. New header for collections. Fixing tests. Adding new tests. Open API changes.
aloknerurkar
added a commit
that referenced
this pull request
Apr 15, 2021
File upload handler. New header for collections. Fixing tests. Adding new tests. Open API changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.