-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(postage): stampissuer usability #2063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 21 of 21 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @esadakar and @zelig)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 21 of 21 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @esadakar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
#2038
Steps:
blockNumber
field added to StampIssuerblockThreshold (default: 10)
). This is done to give the best chance to upstream peers to get notified of the batch and hence validate the stamps issued by this Issuer.@agazso @AuHau
Please note the changes in API spec. Some more errors related to postage stamps being added here.
This change is