Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postage): stampissuer usability #2063

Merged
merged 7 commits into from
Jun 14, 2021
Merged

feat(postage): stampissuer usability #2063

merged 7 commits into from
Jun 14, 2021

Conversation

aloknerurkar
Copy link
Contributor

@aloknerurkar aloknerurkar commented Jun 11, 2021

#2038

Steps:

  1. We create the StampIssuer with the blockNumber of the batch creation event on-chain.
  • New blockNumber field added to StampIssuer
  • Marshal/Unmarshal changes to store the same to statestore
  1. StampIssuer uses the postage store to read the current chain state which informs us what the current block number the node is synced to.
  2. When the postage service provides the StampIssuer, we will check the current block number the node is synced to is greater than the batch creation block number by a certain amount (blockThreshold (default: 10)). This is done to give the best chance to upstream peers to get notified of the batch and hence validate the stamps issued by this Issuer.

@agazso @AuHau
Please note the changes in API spec. Some more errors related to postage stamps being added here.


This change is Reviewable

@aloknerurkar aloknerurkar added the ready for review The PR is ready to be reviewed label Jun 11, 2021
@Eknir Eknir added this to the 42 milestone Jun 11, 2021
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 21 of 21 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @esadakar and @zelig)

Copy link
Member

@istae istae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 21 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @esadakar)

Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@aloknerurkar aloknerurkar merged commit 1e58ecf into master Jun 14, 2021
@aloknerurkar aloknerurkar deleted the stampissuer.0 branch June 14, 2021 08:09
acud pushed a commit that referenced this pull request Jun 14, 2021
acud pushed a commit that referenced this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants