Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics for non closest storer #2509

Merged
merged 1 commit into from
Sep 21, 2021
Merged

feat: metrics for non closest storer #2509

merged 1 commit into from
Sep 21, 2021

Conversation

metacertain
Copy link
Member

@metacertain metacertain commented Sep 15, 2021

Metrics to show how many times replication request came from any other node than the closest connected peer to chunk


This change is Reviewable

Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i have minor suggestions

pkg/pushsync/pushsync.go Show resolved Hide resolved
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @metacertain

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@acud acud merged commit b4ae397 into master Sep 21, 2021
@acud acud deleted the metrics_repl_dist branch September 21, 2021 09:14
@acud acud added this to the v1.2.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants