Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split beekeeper jobs #2560

Merged
merged 11 commits into from
Oct 5, 2021
Merged

ci: split beekeeper jobs #2560

merged 11 commits into from
Oct 5, 2021

Conversation

acud
Copy link
Member

@acud acud commented Oct 2, 2021

This PR splits the beekeeper flow into multiple flows that execute in parallel. It takes down the total CI time to around 16 minutes (from about 30). It also disables metrics on the CI, which removes the beekeeper failures logged when trying to push the metrics (since they are on by default)

This change is Reviewable

@acud acud force-pushed the split-bk branch 2 times, most recently from 0395c3a to 33c2788 Compare October 2, 2021 07:43
@acud acud requested a review from vandot October 2, 2021 08:45
@acud acud self-assigned this Oct 2, 2021
@acud acud added the ready for review The PR is ready to be reviewed label Oct 4, 2021
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vandot)

@vandot
Copy link
Contributor

vandot commented Oct 4, 2021

@acud with setup like this you will push the latest image to dockerhub and deploy to staging if "normal" only/just integration test pass, if clef or incentives tests fail nothing will happen they will not block deployment to staging

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@11f9aa8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2560   +/-   ##
=========================================
  Coverage          ?   63.78%           
=========================================
  Files             ?      232           
  Lines             ?    25734           
  Branches          ?        0           
=========================================
  Hits              ?    16414           
  Misses            ?     7836           
  Partials          ?     1484           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f9aa8...14ae8a7. Read the comment docs.

Copy link
Contributor

@vandot vandot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, we will know if the part of pushing image to dockerhub and deploying to staging works after we merge :)

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@acud acud merged commit 9dd8bc0 into master Oct 5, 2021
@acud acud deleted the split-bk branch October 5, 2021 17:29
@acud acud added this to the v1.2.0 milestone Oct 8, 2021
aloknerurkar pushed a commit that referenced this pull request Oct 10, 2021
Co-authored-by: Ivan Vandot <ivan@vandot.rs>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants