retrieval, pushsync: add tracing #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janos
reviewed
Sep 18, 2020
go.mod
Outdated
| @@ -3,6 +3,7 @@ module github.com/ethersphere/bee | |||
| go 1.14 | |||
|
|
|||
| require ( | |||
| github.com/Azure/go-autorest/tracing v0.5.0 | |||
There was a problem hiding this comment.
Not sure that this is needed, not imported.
pkg/pushsync/pushsync.go
Outdated
| @@ -88,6 +90,8 @@ func (ps *PushSync) handler(ctx context.Context, p p2p.Peer, stream p2p.Stream) | |||
| _ = stream.FullClose() | |||
| } | |||
| }() | |||
| span, _, ctx := ps.tracer.StartSpanFromContext(ctx, "pushsync-handler", ps.logger) | |||
There was a problem hiding this comment.
We can set a tag with address a few lines below, when the delivery is received?
zbiljic
approved these changes
Sep 20, 2020
pradovic
approved these changes
Sep 21, 2020
acud
force-pushed
the
pushsync-tracing
branch
from
c240cdb
to
a50f09b
Compare
acud
force-pushed
the
pushsync-tracing
branch
from
a50f09b
to
d4325e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tracing to pushsync and retrieval