storage incentives: add stamper putter to api #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
postage-pipeline
branch
from
cc91f65
to
b2bb406
Compare
acud
force-pushed
the
postage-pipeline
branch
from
6430ae6
to
b599c00
Compare
acud
force-pushed
the
storage-incentives
branch
2 times, most recently
from
134fa9a
to
cbd4d4a
Compare
acud
force-pushed
the
postage-pipeline
branch
from
c070f13
to
5ece9af
Compare
zelig
force-pushed
the
storage-incentives
branch
from
cbd4d4a
to
97b2a15
Compare
acud
force-pushed
the
postage-pipeline
branch
from
5ece9af
to
948c43b
Compare
acud
commented
Dec 10, 2020
| mode, encrypt := requestModePut(r), requestEncrypt(r) | ||
| return func(ctx context.Context, r io.Reader, l int64) (swarm.Address, error) { | ||
| pipe := builder.NewPipelineBuilder(ctx, s, mode, encrypt, nil) | ||
| return builder.FeedPipeline(ctx, pipe, r, l) | ||
| } | ||
| } | ||
|
|
||
| func requestStamper(post postage.Service, signer crypto.Signer, batch []byte) (postage.Stamper, error) { | ||
| i, err := post.GetStampIssuer(batch) |
There was a problem hiding this comment.
post.GetStamper(batch,signer)
acud
force-pushed
the
postage-pipeline
branch
from
534e14f
to
5727b4d
Compare
acud
commented
Dec 12, 2020
pkg/file/pipeline/stamp/stamp.go
Outdated
|
|
||
| func (w *stampWriter) ChainWrite(p *pipeline.PipeWriteArgs) (err error) { | ||
| addr := swarm.NewAddress(p.Ref) | ||
| p.Stamp, err = w.stamper.Stamp(addr) |
There was a problem hiding this comment.
this sets the stamp on the pipe write args, but does not implement the change which adds the stamp to the actual chunk which is in turn stored on the localstore. i suggest that this change is done in one PR (change to the chunk interface + persistence in localstore)
acud
added
ready for review
acud
changed the title
zelig
approved these changes
Dec 14, 2020
|
@zelig but the CI is failing. I don't know any way around that, particularly that deepsource scans different parts of the codebase randomly on different PRs 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#873
changes that were made outside the scope of this PR are due to complaints from deepsource.