This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
Global store #1174
Closed
Global store #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Jan 31, 2019
| // Returned cleanup function should be called only if err is nil. | ||
| func newServer(ctx *cli.Context) (server *rpc.Server, cleanup func(), err error) { | ||
| log.PrintOrigins(true) | ||
| log.Root().SetHandler(log.LvlFilterHandler(log.Lvl(ctx.Int("verbosity")), log.StreamHandler(os.Stdout, log.TerminalFormat(true)))) |
There was a problem hiding this comment.
please remove the colouring (last param that is currently true) - it fucks up logs on ES/Kibana.
nonsense
reviewed
Feb 5, 2019
| } | ||
| time.Sleep(10 * time.Millisecond) | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
This looks wrong, isn't err shadowed in the for loop above?
There was a problem hiding this comment.
Ups, I missed that. Fixed. Thanks.
nonsense
approved these changes
Feb 5, 2019
|
After merging this, we should update |
zelig
approved these changes
Feb 6, 2019
|
Submitted upstream ethereum/go-ethereum#19014. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new binary
global-storewhich only stores data from swarm nodes that connect to it by RPC. In the future, global store should provide interface to query stored data for chunk explorer, or to implement chunk explorer directly.This PR also adds a new swarm configuration option to specify endpoint for global store api.