This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
network: bump proto versions due to change in OfferedHashesMsg #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: #1422 |
|
i'm not sure i understand why we need to increment |
|
actually, i think we don't need to increment either of them. we should just increment |
|
@acud if we only increment |
|
considering the functionality in suggestpeer, you might end up with peers in a given bin that you are not even syncing with - something that we want to avoid generally. |
|
alrighty. i would at least expect |
|
@acud not sure what you mean - i am increasing all three here - bzz, hive and stream. |
acud
approved these changes
Jun 13, 2019
|
blind. sorry. merge 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the PR which removed dead code, which removes a field from the OfferedHashesMsg.