Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm & fix lerna & ancient oracle #184

Merged
merged 4 commits into from
May 15, 2024
Merged

npm & fix lerna & ancient oracle #184

merged 4 commits into from
May 15, 2024

Conversation

0xSulpiride
Copy link
Member

@0xSulpiride 0xSulpiride commented May 14, 2024 •
edited
Loading

Description

  • made all packages public (to publish on npm)
  • updated lerna (as in v1)
  • added ancient8 gas price & l1 fee oracles

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride requested a review from arddluma May 14, 2024 09:52
@0xSulpiride 0xSulpiride changed the title publish v2 on npm npm & fix lerna & ancient oracle May 15, 2024
ch4r10t33r
ch4r10t33r approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSulpiride 0xSulpiride merged commit 5e22d97 into develop May 15, 2024
1 of 3 checks passed
@0xSulpiride 0xSulpiride deleted the npm-v2 branch May 15, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r