Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mantle sepolia fix #191

Merged
merged 3 commits into from
May 22, 2024
Merged

Mantle sepolia fix #191

merged 3 commits into from
May 22, 2024

Conversation

0xSulpiride
Copy link
Member

Description

  • feat: added config param estimationGasLimit to set gas limit floor in estimation calls
  • added unit tests for that too

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pls can we release this on v2 as well?

@0xSulpiride 0xSulpiride merged commit 603cff2 into master May 22, 2024
3 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the mantle-sepolia-fix branch May 22, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r