Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Update AnalyticsEvent.local_host for non-endpoint events #1029

Closed
pattisdr opened this issue Aug 3, 2022 · 1 comment · Fixed by #1130
Closed

Update AnalyticsEvent.local_host for non-endpoint events #1029

pattisdr opened this issue Aug 3, 2022 · 1 comment · Fixed by #1130
Assignees
@pattisdr
Labels
enhancement New feature or request

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Aug 3, 2022 •
edited by mfbrown
Loading

❗ Blocked by ethyca/fideslog#75

Is your feature request related to a specific problem?

Not all AnalyticsEvents are triggered from an API endpoint, some are from processing tasks in a queue. Therefore, local_host does not always have a value.

Describe the solution you'd like

Update the rerun_access_graph/rerun_erasure_graph and privacy_request_execution_failure events to send localhost=None instead of local_host=False.

Currently, local_host is not allowed to be null.

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.
@pattisdr pattisdr added the enhancement New feature or request label Aug 3, 2022
@pattisdr pattisdr mentioned this issue Aug 3, 2022
Merged
10 tasks
@pattisdr pattisdr self-assigned this Aug 22, 2022
@pattisdr pattisdr mentioned this issue Aug 22, 2022
Merged
10 tasks
sanders41 pushed a commit that referenced this issue Aug 23, 2022
@pattisdr
Fix localhost setting for non-endpoint analytics calls [#1029] (#1130)
36cc41e 
* Set local_host to None for non-endpoint analytics calls.  These are logging various tasks coming out of celery.

* Update Changelog.
@pattisdr
Copy link
Contributor Author

thank you @sanders41 !

sanders41 pushed a commit that referenced this issue Sep 22, 2022
@pattisdr
Fix localhost setting for non-endpoint analytics calls [#1029] (#1130)
5e937ad 
* Set local_host to None for non-endpoint analytics calls.  These are logging various tasks coming out of celery.

* Update Changelog.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pattisdr pattisdr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix localhost setting for non-endpoint analytics calls [#1029] ethyca/fidesops
1 participant
@pattisdr