-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice solution!! I left some comments, but overall wasn't sure how thorough you wanted me to be on this review or if this is still an early stage thing. seems promising, though!
out of curiosity, did you ever try the solutions suggested in ethyca/fides#942? I haven't tried them, but it'd be cool if there's a solution on the nextjs side of things (I'm of the opinion that this is a nextjs problem, since regular ol' servers can't handle this either)
@allisonking Thanks for the feedback! I took a look at The documentation says
and
From my understanding it seems like we would end up with the same static build but the routes and files that are generated would be based on the |
* Add initial POC for dynamic routing * fix a couple lints * Fix mypy lint * making pylint happy * Remove log * Fix another pylint issue * Add docstring * Update index if check * Handle nested nextjs routes * Update changelog
Purpose
This PR implements a routing behavior that makes it possible for the webserver to serve dynamic urls for the frontend. It works by scanning the build directory and building out all of the routes dynamically based on all of the
html
files and directories within it. This works by taking advantage of the fact that the frontend routes have a 1:1 match with the files and directories in the build folder.Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1101