-
Notifications
You must be signed in to change notification settings - Fork 16
Create finished audit log for privacy requests #1040
Create finished audit log for privacy requests #1040
Conversation
"action": AuditLogAction.finished, | ||
"message": "", | ||
}, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that would be nice here is to wrap this new AuditLog
creation into a transaction with privacy_request.save(...)
— if one of these operations fails without the other we'd end up with an incomplete state, so it's better to commit them both at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find. That is a potential issue when approved/denied are created as well. All of the audit logs should probably be updated at the same time when this is done.
Would you like this to be addressed in this PR or a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it as a follow-up
* Add finished AuditLog * Bump fideslib * Update test * Fix format lints * Lowercase encoding * Update changelog * Fix issue with migration downgrade * Sort lists in test data tests * format file
Purpose
Add
AuditLog
for finished requests so users can easily see when they're done.Changes
AuditLogAction
AuditLog
when a subject request finishesChecklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1022