-
Notifications
You must be signed in to change notification settings - Fork 16
Add option to login as root user from config #1116
Conversation
@@ -128,8 +130,10 @@ def prepare_and_log_request( | |||
|
|||
app.include_router(api_router) | |||
app.include_router(user_router, tags=["Users"], prefix=f"{V1_URL_PREFIX}") | |||
app.dependency_overrides[lib_get_config] = get_config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
still trying to verify locally, right now I can't login due to a 400 on the OPTIONS request http://0.0.0.0:8080/api/v1/login but this may be unrelated. |
OK I was able to login, still getting this bg error in the UI, I'm going to switch to main and see if I can duplicate there, I don't think this would be related at first glance? You have to have privacy requests in your db. @sanders41 and I also discussed deprecating the superuser script which was originally created to let you make the "first user" which could then create other users, but this functionality does the same thing, without creating an actual user or client object. |
Ignore the bg error, this was something due to a new privacy request status on my local machine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing this "create_superuser" script while you were here, it makes sense to me to just have one way to create this root user.
Co-authored-by: Paul Sanders <pau@ethyca.com>
Purpose
❗ This won't work until fideslib 3.1.0 is released.Allows logging in with a root user set in the config.
Changes
get_config
get_config
root_username
androot_password
tofidesops.toml
root_user_scopes
to the default configChecklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1067