Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small extension to CMakelist of "towr_ros" package #31

Closed
JaFeKl opened this issue Jul 21, 2018 · 1 comment
Closed

Small extension to CMakelist of "towr_ros" package #31

JaFeKl opened this issue Jul 21, 2018 · 1 comment

Comments

@JaFeKl
Copy link

JaFeKl commented Jul 21, 2018

Hello guys,

I am currently implementing my robot model to work with your package. I just have a minor suggestion:
When people like me try to use header files from the towr_ros package it would be convenient if you install the header files of it by changing the CMakeList of the "towr_ros" package:

include_directories(
  include
  ${catkin_INCLUDE_DIRS}
)
# Mark header files for installation
install(
  DIRECTORY include/${PROJECT_NAME}/
  DESTINATION ${CATKIN_PACKAGE_INCLUDE_DESTINATION}
  FILES_MATCHING PATTERN "*.h"
)

Then people, who download your software and try stuff out don't have to face issues when compiling because of header files, which weren't found :)

@awinkler
Copy link
Member

Thanks, that makes sense and will be implemented. You can also just open a pull-request if you want.

@awinkler awinkler closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants