New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quadrotor model linked to generated model from pipeline #89
Conversation
923a56b
to
87ed2d7
Compare
0ee30f0
to
f573785
Compare
80bf982
to
06a7575
Compare
0202821
to
372e7ff
Compare
@manumerous The pipeline is set(for force), but it seems like the estimated thrust is not able to lift the vehicle up from the ground.
|
372e7ff
to
31ccba7
Compare
This PR adds a multirotor model of the data driven dynamics model
ef0c282
to
bc9aea4
Compare
Sorry if this was unclear. The other models, apart from the tiltwing were estimating accelerations instead of forces. But as it seems from #107 you figured that out by now. :) |
@manumerous Since this PR seems to be growing, I suggest that we merge this at the current state (flying with forces) I have already tried adding moments and drag to the model, but this seems to be very unstable. (most likely due to having different moment of inertia in the sim and the estimation). Therefore, I will address it in a separate PR |
I can have a look at it on Tuesday. If you want to go ahead before its okay for me. |
double vertical_rot_drag_lin{0.07444735702448266}; | ||
double vertical_rot_thrust_lin{-0.0017229667485354344}; | ||
double vertical_rot_thrust_quad{4.0095427586089745}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the data-driven-dyanmics pipeline each rotor is assigned to a rotor group (e.g. vertical) whereby all rotors from the same group share the same coefficients. To distinguish the coefficients the name of the group is added before the coefficients name.
If I understand correctly this rotor parameters are not specific to multi-rotors but general? Would it not make sense to keep the naming general in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not feasible with the yaml parser macro in this repo. The variable name needs to be exactly the same as what you are parsing from the results file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to implement that for other models like for example the delta quadplane, which has two different groups of rotors? Could we maybe get the names of the rotor groups out of the config file and then generate the variables needed to access all the values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manumerous I am not sure - I have not looked into the quadplane yet. I am just trying to parse whatever config variables there is in the config file, and the API currently in this repo requires you to have the same variable name with what you are parsing. If we want a better config management then we need to discuss what we want 😄 However, I don't think this is relevant for this PR.
Could we maybe get the names of the rotor groups out of the config file and then generate the variables needed to access all the values?
I am actually not sure if I understand what you mean. I think this depends more on how the config file is being generated? Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
How do you plan to structure the generation of different models in gazebo? will all different vehicle type dynamics be generated from the file |
Yes, so nothing should change on the gazebo side. Gazebo should be just reading configs and applying them |
635dcf2
to
e03e65d
Compare
e03e65d
to
10f94ab
Compare
Problem Description
This PR adds the capability of linking the generated parametric model into the gazebo simulation for multirotors.
Additional Context