Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kalibr_camera_validator with approximateSynchronize ? #33

Closed
msanfourche opened this issue Nov 3, 2015 · 1 comment
Closed

Kalibr_camera_validator with approximateSynchronize ? #33

msanfourche opened this issue Nov 3, 2015 · 1 comment
Labels
bug Something isn't working

Comments

@msanfourche
Copy link

Hi,

The current kalibr_camera_validator uses the strict time synchronizer included in message_filters. Since Indigo, message_filters for Python includes ApproximateTimeSynchronizer which will enlarge the usage of kalibr_camera_validator to a larger community of users.

The modification seems simple. I have replaced, in line 105,
sync_sub = message_filters.TimeSynchronizer([val.image_sub for val in self.monovalidators],1)
by
sync_sub = message_filters.ApproximateTimeSynchronizer([val.image_sub for val in self.monovalidators],2,0.01)

Best regards.

Martial Sanfourche (ONERA, France)
@tkkhuu tkkhuu mentioned this issue Apr 15, 2019
Closed
@goldbattle goldbattle added the bug Something isn't working label Jun 2, 2022
@goldbattle
Copy link
Collaborator

Should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goldbattle @msanfourche