Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuffer updated to version 2.6.1 #69

Merged
merged 1 commit into from
Dec 18, 2015
Merged

Conversation

ffurrer
Copy link
Contributor

@ffurrer ffurrer commented Jun 26, 2015

No description provided.

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@simonlynen
Copy link
Contributor

DON'T MERGE

@schneith
Copy link

schneith commented Jul 2, 2015

What is the problem with the upgrade?

@ffurrer
Copy link
Contributor Author

ffurrer commented Jul 2, 2015

I don't know, @tcies, @simonlynen, did you resolve the issue?

@simonlynen
Copy link
Contributor

@schneith this breaks map-api tests.

@tcies
Copy link
Contributor

tcies commented Dec 18, 2015

I'm merging this. Apart from the need to rm old protobuf generated headers and sources, map_api and viba unit tests work, as does loading in, visualizing and checking consistency of an old map.

@tcies
Copy link
Contributor

tcies commented Dec 18, 2015

(this update seems to speed things up, and we need speed right now)

@tcies
Copy link
Contributor

tcies commented Dec 18, 2015

Will send out an e-mail with instructions on proto deleting to the muma mailing list.

tcies added a commit that referenced this pull request Dec 18, 2015
protobuffer updated to version 2.6.1
@tcies tcies merged commit 8d06638 into master Dec 18, 2015
@tcies tcies deleted the feature/update_protobuf branch December 18, 2015 09:53
@tcies
Copy link
Contributor

tcies commented Dec 18, 2015

Actually, let me run a multiarch build first...

@tcies
Copy link
Contributor

tcies commented Dec 18, 2015

Ooops, breaks some tango loader test. Will tal asap.

@tcies
Copy link
Contributor

tcies commented Dec 18, 2015

This is incompatible with the precompiled tango libs. :(

@simonlynen
Copy link
Contributor

If you need help with updating these write me a mail

On Fri, Dec 18, 2015, 08:42 Titus Cieslewski notifications@github.com
wrote:

This is incompatible with the precompiled tango libs. :(


Reply to this email directly or view it on GitHub
#69 (comment)
.

@tcies
Copy link
Contributor

tcies commented Dec 18, 2015

mail sent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants