Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color image ISO speed for Capture #176

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

hobbitsyfeet
Copy link
Contributor

  • Python Function called color_iso_speed since the iso "speed" (What Microsoft calls it) is currently only available for color images.
  • Color iso speed property documentation is just copied from Microsoft's page
  • This function must call Capture.color before requesting (like other color image functions)
  • ISO speed is 0 when not available and raises "Cannot read iso from color_image" when 0 is returned.
  • "Color image missed" when the image is not returned in pyk4a.cpp definition.
  • Testing simply tests if capture.color_iso_speed is not None (initialized as none, 0 if error)
  • Tested and works on live capture from the camera and not playback.

- Python Function called color_iso_speed since the iso "speed" (What Microsoft calls it) is currently only available for color images.
- Color iso speed property documentation is just copied from Microsoft's page
- This function must call Capture.color before requesting (like other color image functions)
- ISO speed is 0 when not available and raises "Cannot read iso from color_image" when 0 is returned.
- "Color image missed" when image is not returned in CPP definition.
- testing simply tests if capture.color_iso_speed is not None (initialized as none, 0 if error)
- Tested and works on live capture from the camera, and not playback.
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #176 (3ba32af) into develop (27af48d) will decrease coverage by 0.66%.
The diff coverage is 30.00%.

❗ Current head 3ba32af differs from pull request most recent head 8f5f801. Consider uploading reports for the commit 8f5f801 to get more accurate results

@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
- Coverage    81.38%   80.71%   -0.67%     
===========================================
  Files           12       12              
  Lines          768      778      +10     
===========================================
+ Hits           625      628       +3     
- Misses         143      150       +7     
Impacted Files Coverage Δ
pyk4a/capture.py 61.53% <30.00%> (-2.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lpasselin
Copy link
Collaborator

lpasselin commented Aug 4, 2022

@lpasselin lpasselin merged commit 50a5e03 into etiennedub:develop Aug 4, 2022
lpasselin added a commit that referenced this pull request Feb 3, 2023
* Color image ISO speed for Capture (#176)

* Fixing the context manager for playback objects (#181)

* Fix: setuptools 67 needs python_requires instead of install_requires (#196)

* Added method for getting the extrinsic transformation parameters (#192)

* update python versions for github actions (#197)

* Update black, flake8 and mypy (#198)

---------

Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com>
Co-authored-by: Louis-Philippe Asselin <lpasselin@users.noreply.github.com>
Co-authored-by: David Dunn <qenopster@gmail.com>
Co-authored-by: David Dunn <dunn@qti.qualcomm.com>
Co-authored-by: Ilya Gruzinov <igruzinov@yandex.ru>
Co-authored-by: annStein <43335656+annStein@users.noreply.github.com>
Co-authored-by: steinimoto <as@motognosis.com>
Co-authored-by: Justin <lego.man.123@hotmail.com>
Co-authored-by: CMU <ch.chrismuller@pm.me>
Co-authored-by: Marcel Egle <97447968+EgleM2022@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants