Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: fix gcc warnings #2563

Merged
merged 12 commits into from
May 10, 2024
Merged

general: fix gcc warnings #2563

merged 12 commits into from
May 10, 2024

Conversation

Aciz
Copy link
Member

@Aciz Aciz commented May 10, 2024

Should fix all the warnings that GCC produces.

Aciz added 12 commits May 10, 2024 14:39
This shouldn't ever happen anyway as you can't have an empty filename, but this would blow up if it somehow happened.
Should clean up the entire LUA code from tvgame really as it's not used there.
CURLOPT_PROGRESSDATA has been deprecated in favor of CURLOPT_XFERINFOFUNCTION, the functionality remains the same however.
Flip-flop CMD_BACKUP/MASK_VET to CMD_BACKUP/MASK and add CMD_BACKUP/MASK_ETL with the increased size in order to avoid redefinition of CMD_BACKUP in server.h
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Aranud Aranud merged commit 6cb533d into etlegacy:master May 10, 2024
9 checks passed
Aranud pushed a commit that referenced this pull request May 11, 2024
CURLOPT_XFERINFOFUNCTION takes curl_off_t (long) as args instead of double
rafal1137 pushed a commit to rafal1137/etlegacy that referenced this pull request May 14, 2024
CURLOPT_XFERINFOFUNCTION takes curl_off_t (long) as args instead of double
rafal1137 added a commit that referenced this pull request May 20, 2024
* src: port initial commit from corec branch

q_math.h and rest of the renderer2 .c and .h files not included

* etmain: update some materials

* qcommon: this  was removed due to changes in q_math.h file

* some few updates on material and q_math.c

* qcommon: get back to old solution here

* there are still changes comming in

* qcommon: some changes in q_math.c

* additional changes in q_math.c and ETLBuildRendere.cmake

* cmake: remove it for now

* qcommon: additional changes in q_math.c

* changes in material and glsl shaders

* etmain: small update on materials mp_siwa.share

* etmain: some test on materials mp_siwa shader

* renderer2 : glsl increase value

* one of the biggest changes to rend2

* more materials and glsl changes

* materials and glsl updates

* This commit updates materials and glsl files from commit look bellow

fa106ca
No rend2 files included

* more updates for materials and glsl files

4e3f087

* Commit: bellow

65e1e0e

* more updates

* Commit below

1fa180e

* Commit below: LARGEADRESS use more than 2GB for an app 32/64bit

4ec74d8

* cmake: added WINDOWS_IGNORE_PACKING_MISMATCH

This may result in memory corruption due to win headers being repacked in another way

* Commit bellow

2896651

* Commit below

3a05774

* Commit below

be43862

* Commit below, use largeadressaware in debug builds for now safe bet

c517b38

* Commit below

d3839c3

* cmake: remove /Zp16 packing and few debug  /Od

* Commit below

8206947

* Commit Below

bab276e

* cmake: add missing parenthesis

* cmake: we use ENABLE_SSE here

* cmake: set sse2 and other compiler flags for all project

Should it be only applicable for renderer2 ?

* renderer2: Update tr_animation_mdm.c

I will be updating file one by one just to make it easier for later debuging purposes

* renderer2: Update tr_animation.c

* renderer2: Update tr_backend.c

* renderer2: Update tr_bsp.c

* renderer2: Update tr_cmds.c

* renderer2: Update tr_curve.c

* renderer2: Update tr_decals.c

* renderer2: Update tr_extra.c

* renderer2: Update tr_extra.h

* renderer2: Update tr_fbo.h

* renderer2: Update tr_flares.c

* renderer2: Update tr_fog.c

* renderer2: Update tr_gl.c

* renderer2: Update tr_glsl.c

* renderer2: Update tr_glsldef.h

* renderer2: Update tr_growlist.c

* renderer2: Update tr_image_dds.c

* renderer2: Update tr_image.c

* renderer2: Update tr_init.c

* renderer2: Update tr_light.c

* renderer2: Update tr_local.h

* renderer2: Update tr_main.c

* renderer2: Update tr_marks.c

* renderer2: Update tr_mesh.c

* renderer2: Update tr_model_md3.c

* renderer2: Update tr_model_md5.c

* renderer2: Update tr_model_mdc.c

* renderer2: Update tr_model_mdm.c

* renderer2: Update tr_model_psk.c

* renderer2: Update tr_model_skel.c

* renderer2: Update tr_model_skel.h

* renderer2: Update tr_model.c

* renderer2: Update tr_scene.c

* renderer2: Update tr_shade_calc.c

* renderer2: Update tr_shade.c

* renderer2: Update tr_shader_r1.c

* renderer2: Update tr_shader.c

* renderer2: Update tr_shader.h

* renderer2: Update tr_shadows.c

* renderer2: Update tr_skin.c

* renderer2: Update tr_sky.c

* renderer2: Update tr_surface.c

* renderer2: Update tr_vbo.c

* renderer2: Update tr_world.c

* renderer2: Update tr_thread.c

* cgame: fix compilation errors

* qcommon: fix compilation errors

* renderer2: fix compilation

* qcommon: there are a lot of changes in q_math.h file but for now port just few lines

* cmake: enable renderer2 and sse set

* qcommon: we should atleast have windows and linux done with headers files for sse

* renderer2: update glsl files

Commit from: 7555582

* renderer2: update glsl files

Commit from: e1d1493

* renderer2: update files from latest corec changes

Commit: 7555582

* renderer2: fix compilation errors

* qcommon: fix compilaton, add missing struct initialization

* qcommon: fix compilation errors, use ifndef ETL_SSE

* qcommon: update q_math.h file, there are few things left to fix there and inside q_math.c

* qcommon: remove commented out function statement

* qcommon: fix compilation error

* server: fix compilation error, add missing dot variable

* renderer2: fix more compilation errors

* server: fix missing variables

* renderer2: fix missing variables

* qcommon: when on windows msvc does set sse2/3 macros

On windows you need to use specific macros when using SSE code

* renderer2: update glsl files and some source files from latest core commit

21adf60

* easybuild: enable install of omnibots

* mod: revert scoped weapon testing

* mod: change riflegrenade fireDelayTime to 0, refs #2511

Fixed the weapon charge not drain properly when weapon time is set to 0

* mod: keep unscope behaviour close to vanilla experience

* general: use ETPro bounce sound for mine / satchel, close #1870

Thanks to ETPro team !

* qcommon: there were macros duplications, move non sse ones into right place

* qcommon: there was missing struct name

* qcommon: fix compilation error

Replace out with vecc

* Fixed the cinematic playback when using an FBO, fixes #2002

* minor cleanup and pow2 fixes

* files: simplify the pack isolation code a bit

* r1: cleanup

* cgame: use VectorSet macro instead of vector_set

* qcommon: _M_IX86_FP is always defined even when ETL_SSE was disabled

* renderer2: add missing tr_pbo.c file

* qcommon: add missing macros

* qcommon: add missing vec4_sub

* qcommon: move VectorSubstractDP outside #ifdef

* Uncrusfity all files

* easybuild: windows enable rend2 by default add option to set to enable SSE

* easybuild: windows add missing D

* cgame: lerp lean angles in spec/demo playback

Lean angles were not interpolated while spectating/demo playback, which caused the angle transitions to be choppy since there was no lerp performed between snapshots.

* game: add g_luaModuleList + increase maximum of Lua modules

* game: add g_luaModuleList cvar

The file named by this cvar can contain a list of Lua modules to be
loaded. It replaces the older lua_modules cvar.

* game: increase the limit of loaded Lua modules

With the new g_luaModuleList cvar, it is now easy to load more Lua
modules.

* ui: fix potential out of bounds read with uiInfo.map/campaignList

Since UI_LoadArenasFromFile increases the mapcount before it checks for the limits, it will happily increase the count beyond MAX_MAPS limit. While this is sort of stupid by design, it's more convenient to cap it here so the warning about large amount of pk3 files can be displayed easily. This way the user also knows that they have too many maps.

* ui: Add timerReset bind to Controls > Advanced menu 

This is pretty useful command that is only possible to bind through console or editing config.
Also add default bind N timerReset, skipping default_android.cfg because I don't really know what to use there.

* cgame: fix viewangles jittering when riding on movers, fixes #2464

Co-authored-by: ryzyk-krzysiek <ryzyk-krzysiek@users.noreply.github.com>

* game: show actual filename in warning when platforms.manifest is not found

* qcommon: not sure if we need SSE3 set it to SSE2

* cmake: add specific compiler flags for linux when SSE is enabled

* Update from latest core commit

c317159

* renderer2: update from latest commit

f6e4164

* qcommon: apparently Linux does not like such things even commented

* Revert "qcommon: not sure if we need SSE3 set it to SSE2"

This reverts commit 5b43876.

* renderer2: fix compilation errors on Linux

* renderer2: update with latest changes from core branch

Commit: a8d3dc9

* renderer2: fix missing declarations, remove initialization/assignment of numImageLoaders

* renderer2: this should be altest linux equivalent of mutex threating in linux

* server: fix missing curly parenthesis

This was driving me nuts

* cmake: add cmake files specific for assembly addition

* qcommon: add asm file for SinCos function its it not finished yet

More info here: https://stackoverflow.com/questions/25418967/cmake-how-to-avoid-link-error-when-the-project-contains-asm-masm-sources-with

* qcommon: add x64 SinCos asm

* cmake: append every asm file it finds into COMMON_SRC

* cmake: fix typo

* general: fix gcc warnings

* renderer: remove unused functions

* cgame: remove unused macros & variables

* cgame: fix unambiguous usage of && and || in conditional statement

* qcommon: exclude FS_AddPackToPath from dedicated server

* qcommon: ensure packName doesn't point to null terminator

This shouldn't ever happen anyway as you can't have an empty filename, but this would blow up if it somehow happened.

* game: remove unused variable

* server: remove unused variables

* tvgame: remove unused variables

Should clean up the entire LUA code from tvgame really as it's not used there.

* qcommon: remove unused function

* qcommon: replace deprecate cURL function

CURLOPT_PROGRESSDATA has been deprecated in favor of CURLOPT_XFERINFOFUNCTION, the functionality remains the same however.

* omni-bot: fix incorrect memset on non-trivial datatype

* client: fix redefinition of CMD_BACKUP, refs #2494

Flip-flop CMD_BACKUP/MASK_VET to CMD_BACKUP/MASK and add CMD_BACKUP/MASK_ETL with the increased size in order to avoid redefinition of CMD_BACKUP in server.h

* general: Find cjson on Fedora, where cmake config is missing

* Provide simple helper for cJSON location

If BUNDLED_LIBS is disabled and cjson library does not ship its cmake
config for some reason, attempt to find it the other way. That is the
case on current Fedora cjson package.

Provide CJSON_LIBRARY in addition to CJSON_LIBRARIES variable.

* Remove compat CJSON_LIBRARY variable usage

Use just CJSON_LIBRARIES similar to other modules.

* Try cJSON config-only search as the first step

Use config by default even when FindcJSON module is preferred. Try
CONFIG only and if that works, not not attempt other methods. Should
behave exactly the same way as if FindcJSON module were not present.

* qcommon: fix downloads not showing progress, refs #2563

CURLOPT_XFERINFOFUNCTION takes curl_off_t (long) as args instead of double

* server: "sv_hidden" blocked incoming clients due to mandatory info request, fixes #2256

When "sv_hidden" is enabled now, the challenge value is checked to be a
valid active challenge, and if so, then the info request is responded to.

* game: fix bot doesn't received 2nd weapon, fixes #2565

* game: tiny refactor of team_riflegrenades check

* renderer2: correct OptimazeStages

0c217f4

* renderer2: render_liquid() can now render liquidmap+bumpmap stage too

9e839d8

* renderer2: globalfog bugfix fog on/off at certain areas/orientations/angles

* renderer2:  fogs scale (depth for opaque)

* renderer: port from corec branch

9ee1fa0

* renderer2: fix compilation error, C&P Error

* qcommon: some clean up in q_math files

* cmake: SSE and RENDERER2 needs to be checked on other systems too, turning it off atm

* uncrustify: replace all crlf to lf, and use proper spacing/tabbing

---------

Co-authored-by: Aranud <aranud66@live.fr>
Co-authored-by: Jacker <shogaiam@gmail.com>
Co-authored-by: Aciz <arto.karkulahti@gmail.com>
Co-authored-by: Elouan Martinet <11819703+Exagone313@users.noreply.github.com>
Co-authored-by: Michal 'Kimi' Mitter <mittermichal@protonmail.com>
Co-authored-by: ryzyk-krzysiek <ryzyk-krzysiek@users.noreply.github.com>
Co-authored-by: Petr Menšík <pemensik@fedoraproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants