Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrostonModel #38

Closed
Mr-Geekman opened this issue Aug 14, 2023 · 0 comments
Closed

CrostonModel #38

Mr-Geekman opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Mr-Geekman
Copy link

Issue by Mr-Geekman
Monday Jul 17, 2023 at 13:57 GMT
Originally opened as tinkoff-ai#1317


🚀 Feature Request

Add model based on Croston's method for intermittent demand.

We could also try to implement some variations of this method.

Proposal

Add CrostonModel.

  • It could be implemeted as per-segment model using BaseAdapter and PerSegmentModelMixin (look at ProphetModel for reference)
  • It could be implemented as NonPredictionIntervalContextIgnorantAbstractModel that saves the answer during the fit
  • During fit it should raise a warning that it doesn't work with exogenous features, look at SeasonalMovingAverageModel

References:

To discuss:

  • Should it be our own implementation or some external package can be used (statsforecast for example)
    • We should try to make our own implementation

Test cases

  • Tests for the model itself
  • Inference tests in tests/test_models/test_inference/.

Additional context

No response

@Mr-Geekman Mr-Geekman added enhancement New feature or request priority/medium Medium priority task labels Aug 14, 2023
@d-a-bunin d-a-bunin removed the priority/medium Medium priority task label May 29, 2024
@etna-team etna-team locked and limited conversation to collaborators May 29, 2024
@d-a-bunin d-a-bunin converted this issue into discussion #358 May 29, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants