Upgrade bitcoin-core/secp256k1 to latest HEAD #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rbspec256k1` is not running on m1 macs. We're seeing this error: etscrivner#54 I dug into the depedencies and noticed that the bitcoin-core/secp256k1 depedency has not been update in 3 years. Using the latest `HEAD` fixed the issue on m1 macs and all tests are passing.
|
Appreciate this! |
chainoperator
added a commit
to q9f/eth.rb
that referenced
this pull request
Dec 1, 2021
`rbsecp256k1` was not compiling on m1 macs. We fixed one of their downstream deps here: etscrivner/rbsecp256k1#55. The maintainer released a new gem version with the fix. This PR upgrades rbsecp256k1 to the latest gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbspec256k1is not running on m1 macs. We're seeing this error: #54I dug into the depedencies and noticed that the bitcoin-core/secp256k1 depedency has not been updated in 3 years. Using the latest
HEADfixed the issue on m1 macs and all tests are passing.