This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Make the user lookup URL configurable #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the hardcoded URL to lookup a user on a 3rd party site. Simply define a lookup_url in the contact section of the config, using a %s where the username should be substituted, eg. http://foo.com/bar/%s
Closed
|
Looks good to me. Could you add some unit tests for the functions so we don't break them in the future? |
|
@mrtazz tests added. |
nkammah
added a commit
that referenced
this pull request
Nov 8, 2013
Make the user lookup URL configurable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the hardcoded URL to lookup a user on a 3rd party site. Simply
define a lookup_url in the contact section of the config, using a %s where the username
should be substituted, eg. http://foo.com/bar/%s