Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Documentation for some algorithms is wrong? #83

Closed
mspiegel opened this issue Apr 30, 2014 · 1 comment
Closed

Documentation for some algorithms is wrong? #83

mspiegel opened this issue Apr 30, 2014 · 1 comment

Comments

@mspiegel
Copy link

In https://github.com/etsy/skyline/blob/master/src/analyzer/algorithms.py in the documentation for functions stddev_from_average, stddev_from_moving_average, and mean_subtraction_cumulation the threshold is stated as one standard deviation. However in the implementations it looks like three standard deviations is the threshold. Am I missing something?

jonlives added a commit that referenced this issue May 2, 2014
@jonlives
Copy link
Contributor

jonlives commented May 2, 2014

@mspiegel you are indeed correct - I've fixed up the docs there, it is indeed 3 stddev.

@jonlives jonlives closed this as completed May 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants