Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks memory pool stats (eden, survivor, tenured, etc.) #19

Merged
merged 2 commits into from
Jul 2, 2015

Conversation

bdarfler
Copy link
Contributor

@bdarfler bdarfler commented Jul 2, 2015

This, along with #18 closes #17

@bdarfler
Copy link
Contributor Author

bdarfler commented Jul 2, 2015

Question about this. There is also a type field to denote on/off heap which I didn't use since I wasn't sure how to best add that to the metric name. It would be nice to support graph all pools of the same type together on one graph. Would it be best to have the metric name be type.name to support this? I'm still new to best practices around statsd naming.

@ajsquared
Copy link
Contributor

What do you think of having the metrics like heap.total, heap.eden, etc and group them that way?

Doing this would require some changes to the dashboard, but that should be pretty straightforward.

@bdarfler
Copy link
Contributor Author

bdarfler commented Jul 2, 2015

Also I believe there could be spaces in the pool names. Is it best to replace them with a hyphen?

@ajsquared
Copy link
Contributor

Yeah, replacing the spaces with hyphens is good.

@bdarfler
Copy link
Contributor Author

bdarfler commented Jul 2, 2015

Ah so you mean like:

heap.total.{init, used, committed, max}
heap.eden.{init, used, committed, max}

I like that.

@ajsquared
Copy link
Contributor

Yeah, those metric names look good.

@bdarfler
Copy link
Contributor Author

bdarfler commented Jul 2, 2015

Ok I updated the metric names and I took a crack at fixing the visualizer. Let me know if I missed anything.

@ajsquared
Copy link
Contributor

Looks great, thanks again for this!

ajsquared added a commit that referenced this pull request Jul 2, 2015
Tracks memory pool stats (eden, survivor, tenured, etc.)
@ajsquared ajsquared merged commit 2d54785 into etsy:master Jul 2, 2015
@ajsquared ajsquared mentioned this pull request Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhanced Memory Metrics
2 participants