-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracks memory pool stats (eden, survivor, tenured, etc.) #19
Conversation
Question about this. There is also a type field to denote on/off heap which I didn't use since I wasn't sure how to best add that to the metric name. It would be nice to support graph all pools of the same type together on one graph. Would it be best to have the metric name be |
What do you think of having the metrics like heap.total, heap.eden, etc and group them that way? Doing this would require some changes to the dashboard, but that should be pretty straightforward. |
Also I believe there could be spaces in the pool names. Is it best to replace them with a hyphen? |
Yeah, replacing the spaces with hyphens is good. |
Ah so you mean like:
I like that. |
Yeah, those metric names look good. |
08160e8
to
6e7e24f
Compare
Ok I updated the metric names and I took a crack at fixing the visualizer. Let me know if I missed anything. |
Looks great, thanks again for this! |
Tracks memory pool stats (eden, survivor, tenured, etc.)
This, along with #18 closes #17