Add a generic --output argument to udevadm hwdb #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonev
reviewed
Sep 30, 2023
Instead of always writing /etc/udev/hwdb.bin or UDEV_LIBEXEC_DIR /hwdb.bin, let the user specify a full file name. * src/udev/udevadm-hwdb.c (adm_hwdb): New option "output". Construct hwdb_bin when processing options, and prepend root after processing options. * man/udev.xml: Mention --output. * man/udevadm.xml: Document --output. * man/udev.7: Regenerate. * man/udevadm.8: Same.
|
I somehow dislike the wording in the man page, e.g. I will merge and fix that afterwards. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear eudev developers,
In Guix, every package is installed in a separate "/usr" prefix. For instance, eudev is installed in "/usr-a/" and upower in "/usr-b/" (except it’s actually "/gnu/store/xxx-eudev-version" and "/gnu/store/yyy-upower-version", whatever). If I want to compile the hwdb database and write it to "/usr-b/lib/udev/hwdb.bin" (with "--usr"), the "--root" argument is insufficient. If I compile with --root=/usr-b, I will end up with "/usr-b/usr-a/lib/udev/hwdb.bin".
I think it would be better to let udevadm hwdb write to an arbitrary file.
What do you think?
Best regards,
Vivien