BAEL-7614 sql.Timestamp to java.util.Calendar conversion #16607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandysimonton1337
force-pushed
the
BAEL-7614-timestamp-to-calendar
branch
from
bcd4556
to
fcbd0fb
Compare
theangrydev
requested changes
May 9, 2024
...ations-4/src/main/java/com/baeldung/timestamptocalendar/SqlTimestampToCalendarConverter.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/baeldung/timestamptocalendar/SqlTimestampToCalendarConverterUnitTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/baeldung/timestamptocalendar/SqlTimestampToCalendarConverterUnitTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/baeldung/timestamptocalendar/SqlTimestampToCalendarConverterUnitTest.java
Outdated
Show resolved
Hide resolved
...ations-4/src/main/java/com/baeldung/timestamptocalendar/SqlTimestampToCalendarConverter.java
Outdated
Show resolved
Hide resolved
|
I apologize for being all over the board! I pushed the changes and also edited the article to reflect the removal of java.time.Instant. |
theangrydev
requested changes
May 11, 2024
|
|
||
| @Test | ||
| public void givenTimestamp_whenConvert_thenEqualMillis() { | ||
| Timestamp timestamp = new Timestamp(124, 3, 19, 9, 30, 0, 801789562); |
There was a problem hiding this comment.
This Timestamp constructor has been deprecated for a very long time (since Java 1.2 AFAIK) - we should really only be using the new Timestamp(long time) constructor + Timestamp.setNanos if you want to control the nanos field
| } | ||
|
|
||
| @Test | ||
| public void givenCalendar_whenConvert_thenLoseNanos() { |
There was a problem hiding this comment.
Suggested change
| public void givenCalendar_whenConvert_thenLoseNanos() { | |
| public void givenTimestamp_whenConvertToCalendarAndBack_thenLoseNanos() { |
| public class SqlTimestampToCalendarConverterUnitTest { | ||
|
|
||
| @Test | ||
| public void givenTimestamp_whenConvert_thenEqualMillis() { |
There was a problem hiding this comment.
Suggested change
| public void givenTimestamp_whenConvert_thenEqualMillis() { | |
| public void givenTimestamp_whenConvertToCalendar_thenEqualMillis() { |
| } | ||
|
|
||
| @Test | ||
| public void givenCalendarFromTimestamp_whenConvertBack_thenEqualMillis() { |
There was a problem hiding this comment.
Suggested change
| public void givenCalendarFromTimestamp_whenConvertBack_thenEqualMillis() { | |
| public void givenCalendarFromTimestamp_whenConvertBackToTimestamp_thenEqualMillis() { |
| assertEquals(nanos, timestamp.getNanos()); | ||
| Calendar calendar = SqlTimestampToCalendarConverter.timestampToCalendar(timestamp); | ||
| timestamp = SqlTimestampToCalendarConverter.calendarToTimestamp(calendar); | ||
| assertNotEquals(nanos, timestamp.getNanos()); |
There was a problem hiding this comment.
Let's do an assertEquals here instead to make it clear what exactly happens to the nanos field vs the original value
sandysimonton1337
force-pushed
the
BAEL-7614-timestamp-to-calendar
branch
from
dc87763
to
b370f51
Compare
theangrydev
approved these changes
May 12, 2024
sandysimonton1337
force-pushed
the
BAEL-7614-timestamp-to-calendar
branch
from
b370f51
to
2afae60
Compare
sandysimonton1337
force-pushed
the
BAEL-7614-timestamp-to-calendar
branch
from
971dd17
to
b351836
Compare
sandysimonton1337
force-pushed
the
BAEL-7614-timestamp-to-calendar
branch
from
b351836
to
ea455f3
Compare
theangrydev
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrating the conversion from java.sql.Timestamp to java.util.Calendar, as well as suggesting the use of Instant.