Allow users to reference own public key secrets #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This should solve #17
Changes
I've extended the secret parsing function to check for the referenced secret (as was the original intention, when reading the docs). The default secret still works as a fallback.
To achieve this, I moved the client to the webhook server itself, to avoid uneccesary creation of multiple k8s clientsets. One is enough to handle the requests we get.
Additionally, I've cleaned up the code base a bit, removed the vendors folder (if there is some reason for it, we can leave it in) and spruced up the documentation.
Tests done
System tests for the following use cases:
Also added some unit tests to get the ball rolling :)