Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/k8schain #39

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Fix/k8schain #39

merged 3 commits into from
Jan 14, 2024

Conversation

eumel8
Copy link
Owner

@eumel8 eumel8 commented Jan 12, 2024 •
edited
Loading

@eumel8 eumel8 requested a review from puffitos January 12, 2024 16:56
puffitos
puffitos approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@puffitos puffitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the UseMountSecrets as well, this shouldn't pose any problems since we're not mounting any secrets in the serviceaccounts anyway.

@eumel8 eumel8 merged commit b22ff08 into main Jan 14, 2024
13 checks passed
@eumel8 eumel8 deleted the fix/k8schain branch January 14, 2024 09:50
@eumel8 eumel8 mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffitos puffitos puffitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The manifest deployment is outdated
2 participants
@eumel8 @puffitos