Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockerHub push #168

Merged
merged 17 commits into from
Apr 21, 2024
Merged

DockerHub push #168

merged 17 commits into from
Apr 21, 2024

Conversation

aurelf
Copy link
Member

@aurelf aurelf commented Apr 21, 2024

A new PR based on DockerHub push #165

  • Test pushing to DockerHub
  • mention dockerhub and test action
  • Only if all tests pass, go to dockerhub
  • You already checking if the Docker image can build completely before pushing so I am just removing this
  • Pushing to DockerHub works. Think best I leave it to anyone forking to make the DockerHub account and secrets to avoid double building the Docker image
  • Add docker push workflow as separate

@aurelf aurelf mentioned this pull request Apr 21, 2024
Closed
@aurelf aurelf merged commit 6b32a38 into eurecom-s3:master Apr 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aurelf @AndrewQuijano