Fix bug#109 #110
Fix bug#109 #110
Conversation
| $('#passwordErrorMessage').text(xhr.responseText) | ||
| $('#passwordErrorMessage').text(xhr.responseText); | ||
| $("#passwordErrorMessage:contains('login')").html(function(_, html) { | ||
| return html.replace(/(login)/g, '<a href="/login">$1</a>'); |
There was a problem hiding this comment.
I don't want to use the responseText at all. The javascript should include its own message.
|
Please review, thanks |
| $("#passwordErrorMessage:contains('login')").html(function(_, html) { | ||
| return html.replace(/(login)/g, '<a href="/login">$1</a>'); | ||
| }); | ||
| $('#passwordErrorMessage').html("Account already exists! You may go ahead and <a href='protected/login'>login</a>."); |
There was a problem hiding this comment.
You need to check the status code and only print your error message if CONFLICT was detected. Otherwise, you need to show a different message or messages.
|
Please review it, thanks |
| @@ -137,7 +137,14 @@ window.eureka.registration = new function () { | |||
| }, | |||
| error: function (xhr, err) { | |||
| $('#passwordChangeFailure').show(); | |||
| $('#passwordErrorMessage').text(xhr.responseText) | |||
| if (xhr.status == "409") { | |||
There was a problem hiding this comment.
Please make this a switch statement. Also, status should be returning a numerical value not a string.
|
She wrote the msg as : |
|
Please review, thanks |
candyam5522
force-pushed
the
master
branch
2 times, most recently
from
de698ef
to
45612df
Compare
…er-webapp needs CAS redirect operation, which does not support POST payload
| @@ -44,7 +44,7 @@ | |||
|
|
|||
| <template:insert template="/templates/eureka_main.jsp"> | |||
| <template:content name="content"> | |||
| <h3>Account Settings ${user.username}</h3> | |||
| <h3>Account Settings1111 ${user.username}</h3> | |||
There was a problem hiding this comment.
This has been fixed in the later commit
|
Please resolve conflicts with pom.xml. Thx. |
|
I just solved the conflict in pom.xml file, you can merge now |
No description provided.