Analyze Build updates #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-updated and tested gulp dependencies that could slow down build - Also upgraded to Angular 1.5 and added in Angular Bootstrap UI
-updated to latest and tested gulp dependencies that could slow down build. Grouping these items together for an easy rollback just in case.
arpost
reviewed
Jan 25, 2017
| <script src="bower_components/angular/angular.js"></script> | ||
| <script src="bower_components/ui-router/release/angular-ui-router.js"></script> | ||
| <script src="bower_components/angular-messages/angular-messages.js"></script> | ||
| <script src="bower_components/jquery/dist/jquery.js"></script> |
There was a problem hiding this comment.
Help me understand the change in load order. We loaded jquery before angular to prevent angular from trying to use the built-in jquery lite. I believe the original load order is correct. The answer to the question, "Does AngularJS use the jQuery library?", in the Angular FAQ (https://docs.angularjs.org/misc/faq) seems to back me up.
|
Corrected JavaScript load order. Ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for changes made to update dependencies and out of date packages. These update may help with speeding up the build process. Also, added in Upgrade to Angular 1.5 and Angular-Bootstrap-UI. There should be no breaking changes. Please do a mvn clean install.