Debt/met 5132 dates normalization cleanup part 4 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd adapt edtf builder
…e class reusing already existent code
jeortizquan
requested changes
Oct 16, 2023
metis-normalization/src/main/java/eu/europeana/normalization/dates/edtf/DateQualification.java
Outdated
Show resolved
Hide resolved
...ormalization/src/main/java/eu/europeana/normalization/dates/edtf/InstantEdtfDateBuilder.java
Outdated
Show resolved
Hide resolved
...ormalization/src/main/java/eu/europeana/normalization/dates/edtf/InstantEdtfDateBuilder.java
Outdated
Show resolved
Hide resolved
...ormalization/src/main/java/eu/europeana/normalization/dates/edtf/InstantEdtfDateBuilder.java
Outdated
Show resolved
Hide resolved
...ormalization/src/main/java/eu/europeana/normalization/dates/edtf/InstantEdtfDateBuilder.java
Outdated
Show resolved
Hide resolved
.../java/eu/europeana/normalization/dates/extraction/extractors/MonthNameDateExtractorTest.java
Outdated
Show resolved
Hide resolved
...ain/java/eu/europeana/normalization/dates/extraction/extractors/DcmiPeriodDateExtractor.java
Outdated
Show resolved
Hide resolved
...ain/java/eu/europeana/normalization/dates/extraction/extractors/DcmiPeriodDateExtractor.java
Outdated
Show resolved
Hide resolved
...ain/java/eu/europeana/normalization/dates/extraction/extractors/DcmiPeriodDateExtractor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/eu/europeana/normalization/dates/extraction/extractors/EdtfDateExtractor.java
Outdated
Show resolved
Hide resolved
jeortizquan
requested changes
Oct 19, 2023
.../src/main/java/eu/europeana/normalization/dates/extraction/extractors/BcAdDateExtractor.java
Show resolved
Hide resolved
...va/eu/europeana/normalization/dates/extraction/extractors/LongNegativeYearDateExtractor.java
Outdated
Show resolved
Hide resolved
...n/java/eu/europeana/normalization/dates/extraction/extractors/NumericPartsDateExtractor.java
Outdated
Show resolved
Hide resolved
.../java/eu/europeana/normalization/dates/extraction/extractors/MonthNameDateExtractorTest.java
Show resolved
Hide resolved
.../europeana/normalization/dates/extraction/extractors/LongNegativeYearRangeDateExtractor.java
Outdated
Show resolved
Hide resolved
I've renamed it wherever I think was reasonable. |
jeortizquan
approved these changes
Oct 19, 2023
jeortizquan
pushed a commit
that referenced
this pull request
Oct 30, 2023
* MET-5132: Update naming of numeric spaces variant * MET-5132: Prepare first sample of tests * MET-5132: More tests * MET-5132: Restructure with enum MontNameDateExtractor * MET-5132: Reusable DatePartsIndices * MET-5132: Cleanup * MET-5132: Add spaces clean and trim * MET-5132: Cleanup * MET-5132: First split the range part * MET-5132: Refactor PatternBcAdDateExtractor with tests * MET-5132: PatternBcAdRangeDateExtractor cleanup * MET-5132: Reuse range code for dates * MET-5132: Reuse range code for BriefRangeDateExtractor * MET-5132: Simplify hierarchy for ranges * MET-5132: Add sample tests for PatternLongNegativeYearDateExtractor and adapt edtf builder * MET-5132: Refactor LongNegativeYearDateExtractor with a separate range class reusing already existent code * MET-5132: Split century extraction to numeric, roman, roman range reusing code * MET-5132: Centralize sanitization operation for all extractors. * MET-5132: Add tests for generic properties * MET-5132: Reuse test code * MET-5132: Repackage * MET-5132: Split EdtfDateExtractor to handle ranges separately with code reuse * MET-5132: Centralize date qualification overwriting * MET-5132: Simplify date qualification overwriting * MET-5132: Update code after answers from rnd * MET-5132: Cleanup * MET-5132: PatternFormattedFullDateDateExtractor cleanup * MET-5132: Add millisecond support * MET-5132: Process review * MET-5132: Process review 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.