Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove SSL blacklist #1896

Merged
merged 14 commits into from
May 10, 2023
Merged

refactor: remove SSL blacklist #1896

merged 14 commits into from
May 10, 2023

Conversation

rwd
Copy link
Contributor

@rwd rwd commented Mar 29, 2023 •
edited
Loading

  • Removes SSL blacklist & SSL negotiation features
    • Blacklist is deemed redundant
    • Without the need for the blacklist, SSL negotiation can be handled by a gateway/reverse proxy
  • Removes redundant custom Nuxt http module
    • Removed injected $path plugin, as vue-i18n's localePath can be used
    • Removed injected $goto plugin, as Vue Router's push can be used
    • Move canonical URL functions to a new mixin
  • Sets Content-Security-Policy: upgrade-insecure-requests SSR response header

@github-actions
Copy link

JIRA ticket: EC-6265

@rwd rwd mentioned this pull request Mar 29, 2023
Closed
@github-actions
Copy link

Preview deployment: https://pr-1896.portal-js.dev.eanadev.org/

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.4% 92.4% Coverage
0.0% 0.0% Duplication

@rwd rwd changed the title refactor: remove SSL blacklist 👋 refactor: remove SSL blacklist May 10, 2023
@lbiedinger lbiedinger merged commit 5703734 into master May 10, 2023
@lbiedinger lbiedinger deleted the refactor/EC-6265-remove-ssl-blacklist branch May 10, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbiedinger lbiedinger lbiedinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwd @lbiedinger