Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computed modalStyle Top miscalculation #302

Closed
bendo01 opened this issue Aug 29, 2018 · 7 comments
Closed

computed modalStyle Top miscalculation #302

bendo01 opened this issue Aug 29, 2018 · 7 comments
Labels

Comments

@bendo01
Copy link

bendo01 commented Aug 29, 2018

Problem:

After Update from version 1.3.18 to version 1.3.23, computed modalStyle Top miscalculation on first call, after i resize my browser window then modal placed on center screen, Being used in SSR app with nuxt

@euvl euvl added the bug label Aug 29, 2018
@euvl
Copy link
Owner

euvl commented Aug 29, 2018

Probably its due to Mutation Observer being moved to utils.

@mijgame
Copy link

mijgame commented Aug 29, 2018

Noticing the same thing; the positioning on first opening is wrong. Removing height="auto" corrects the positioning, but that isn't really a workaround.

@euvl
Copy link
Owner

euvl commented Aug 29, 2018

Check 1.3.24 pls

@mijgame
Copy link

mijgame commented Aug 29, 2018

Tested 1.3.24, it didn't fix it I'm afraid.

@euvl
Copy link
Owner

euvl commented Aug 29, 2018

Then i don't really know what is going on. Will try to investigate.
Meanwhile please stick to the previous version that works for you.
Also feel free to looks through the diff in case you think you might know what the problem is.

Thanks

@crnkovic
Copy link

crnkovic commented Aug 29, 2018

Same thing here, removing height="auto" fixes it. Hopefully the bug is found soon! :)

I found out that the bug was not there on 1.3.20, and was there on 1.3.21. Hopefully that helps.

onmotion added a commit to onmotion/vue-js-modal that referenced this issue Aug 30, 2018
The mutationObserver starts to observe the modal until it appeared
@euvl
Copy link
Owner

euvl commented Aug 30, 2018

@onmotion seems to have fixed an issue. Could you please create a PR?

@euvl euvl closed this as completed in 7982904 Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants