-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation of the app #208
Comments
Thanks! In principle I think this is a good idea, however we need to keep in mind that:
So when we add more translations I would suggest also adding a dialog that informs the user that they are using an "unofficial" translation with the caveats mentioned above. There's already a way to set the language within the app, so they can opt to use English or German instead of their system language if preferred. Do you already have experience with Weblate or other translation platforms and how easy it is to integrate Android XML strings files and to push and pull updates? |
Yes that's totally ok for the moment! Maybe in a "far future" we could imagine a translation feature to translate those text fields on the fly if the user requests it, but what this issue was about is just translating the app itself 👍
That's totally ok too, fall back to english in other cases is really sufficient for the moment!
I'm a native french speaker, so I can asure you that my french translations will be pretty correct and understandable by other french speaking people :) But I understand your concern and the difficulty of reviewing translations of other contributors in other languages. I know that https://github.com/CatimaLoyalty/Android is for example using community maintained translations, and it's working great so far :)
That's totally ok too, and that's how it is done in Catima and it work's great! When changes are made, if the translations are made before the release by fast contributors it's great, but otherwise it just gets integrated later :)
That's up to you, I know in Catima the changelogs get less attention by the contributors, but get integrated if completed. So these could get integrated if completed in other languages if you wish.
Maybe an "unofficial" warning would be too much and weird for the user. I think it would be better to just integrate languages that are ready because their translation is well done and production ready. Having an "unofficial" tag might just confuse the user. The translation does not need to be perfect anyway and could get improved over time if needed :)
Yes I already integrated https://github.com/francoisfds/BikeSharingHub to Weblate and it was a really easy setup process :) All strings get detected automatically and kept up to date with the repo. When users make translations you can choose the way those are integrated back into the project, but one way for example is just for the Weblate bot to open PRs in this repo with the translation changes made :) I hope my answers are helpful and again thanks for your detailed answers! |
I have now added EVMap to Weblate. Let's see how this goes :) Note that I'm currently still in the trial period and the project still needs to be approved for free hosting for open source projects. But in principle it should already be possible to translate strings.
That is definitely a good idea. Do you know a good way how to handle this? I see that Weblate has already opened a PR (#211) with new translations, and I guess that PR will contain translations for all languages, so it wouldn't easily be possible to merge just changes to some of the languages... |
I see that @comradekingu has already started translating the first couple of strings into Norwegian. Thanks! |
That's great, thanks!
I don't know if there is a way to do this, but hopefully there is a way to manage this in Weblate (maybe something like if this translation has reached a certain threshhold (>95%) and is approved by the owner, than a PR can be triggered?) |
@Altonss I now added more detailed context descriptions to the remaining few strings - I hope this helps!
Hmm, didn't find anything like this so far. I guess I'll have to cherry-pick the commits for the respective languages then. |
Ah, there is at least a way to make Weblate squash all commits for one language. That makes it very easy to cherry-pick a single language, which I just did for the French translation 🎉 |
Oh, now Android Lint is complaining due to WeblateOrg/weblate#7520 :( |
You could also just have weblate make one PR per language, I think it's a setting that is possible in the Weblate configuration panel :) |
That's what I was looking for, but I don't see any such option. |
@johan12345 That said I have never experienced limiting translations artificially doing any good. I propose not doing it. People notice something as incomplete is secondary to being able to understand the simpler strings at all for some. The avenues where more people would notice are the bigger languages, and there translations are made available faster. I put in #218 to help smooth out the process of translating in the future. |
It is located in Evmap/Evmap > Manage > Add-ons and there you can find the setting normally :) |
Also I saw that you are translating each language entry in the language setting in the selected language. I don't know if it's a good workflow. What I know from Catima and makes sense is to have each language name written in it's own language so that each user can find his language easily :) |
I agree with you that the fact to "limit" translation might not be the best way of doing, However I also understand @johan12345 who may encounter difficulties managing languages he does not understand and wants to be assured that the translations meet the standards he expect for the user experience... :) |
Yeah, let's see how it evolves. At least I want to have the possibility of merging translations for different languages separately if needed (e.g. if I know that someone is still actively working on a translation I would wait for them to finish before merging) - and that is doable as it's now set up with the squashing plugin. |
The first update with French and Norwegian translations included is now on its way (Play Store release typically takes <1 day unless there are any issues in review, F-Droid release a couple more days until their build server picks it up). Let's close this issue and open other issues/PRs for any specific issues with translations. |
Hello!
I really like this app and am really thankful for it being on Fdroid :) It is currently available in english and german, but I think it would be really cool to also have other languages available! What do you think about integrating a translation tool like Weblate to add new languages?
The text was updated successfully, but these errors were encountered: