Merge pull request #37 from ryden54/hotfix/memory-leak-without-profiler

memory-leak-without-profiler
evaisse · Sep 30, 2021 · 648bb44 · 648bb44
2 parents 26e789c + e1a497e
commit 648bb44
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/DataCollector/ProfilerDataCollector.php b/DataCollector/ProfilerDataCollector.php
@@ -34,7 +34,8 @@
  */
 class ProfilerDataCollector extends DataCollector implements EventSubscriberInterface
 {
-
+    /** @var bool */
+    protected $debug;
 
     /**
      * List of emitted requests
@@ -56,6 +57,13 @@ class ProfilerDataCollector extends DataCollector implements EventSubscriberInte
      */
     protected $stopwatch;
 
+    /**
+     * @param bool $debug
+     */
+    public function __construct(bool $debug)
+    {
+        $this->debug = $debug;
+    }
 
     /**
      * (non-PHPdoc)
@@ -155,6 +163,9 @@ public function normalizeCalls()
 
     public function onPrepare(RequestEvent $event)
     {
+        if (!$this->debug) {
+            return;
+        }
         $request = $event->getRequest();
 
         $eventName = "#" . count($this->calls) . ' ' . $request->getMethod() . ' ' . $request->getUri();
@@ -193,6 +204,9 @@ public function getRequestKey($request)
 
     public function onError(ExceptionEvent $event)
     {
+        if (!$this->debug) {
+            return;
+        }
         $key = $this->getRequestKey($event->getRequest());
 
         $this->errors++;
@@ -208,6 +222,9 @@ public function onError(ExceptionEvent $event)
 
     public function onSuccess(ResponseEvent $event)
     {
+        if (!$this->debug) {
+            return;
+        }
         $key = $this->getRequestKey($event->getRequest());
 
         $this->calls[$key] = array_merge($this->calls[$key], array(

diff --git a/Resources/config/services.yml b/Resources/config/services.yml
@@ -29,6 +29,8 @@ services:
     simple_http.profiler.data_collector:
         class: evaisse\SimpleHttpBundle\DataCollector\ProfilerDataCollector
         public: true
+        arguments:
+            $debug: '%kernel.debug%'
         calls:
             - [ setStopWatch, [ "@debug.stopwatch" ] ]
         tags: