Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error caused by upstream change from uglify-js (#251) #252

Closed

Conversation

lettenj61
Copy link

This patch was originally written for elm-jp/guide by @negiboudu san (ref)

* This patch was originally written for `elm-jp/guide` by @negiboudu san
@David-Klemenc
Copy link

Hi, I remembered coming across this issue a while ago and several PR are in progress to solve it. I think this issue spans multiple repositories and has conflicting PR:

Issues:
#251
elm-lang 849
elm-lang 848

PRs:
compiler (solution with terser)
#240
and this one

I'm using terser, the main advantage is that it only requires one pass:
terser $js --compress "pure_funcs=[F2,F3,F4,F5,F6,F7,F8,F9,A2,A3,A4,A5,A6,A7,A8,A9],pure_getters,keep_fargs=false,unsafe_comps,unsafe" --mangle --output=$min

I think there should be a discussion (maybe on discord?, maybe here?) to solve this reoccurring problem.

@evancz
Copy link
Owner

evancz commented Feb 10, 2021

I believe this is fixed by #258 as well. Just merged that one!

@evancz evancz closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants