Improve performance #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit a742e81 changed only format_parser.kpeg, but it looks like format_parser.rb was not re-generated.
... because the former is faster. Note that we need to use `\\G` instead of `\\A` for regexps. This trivial performance improvement will reduce a few seconds of Ruby's "make install" process because kpeg is used to generate the markdown parser of RDoc.
aycabta
added a commit
to aycabta/rdoc
that referenced
this pull request
Aug 9, 2021
I compared the results between the latest release of kpeg gem (1.1.0) and HEAD of kpeg gem with `time` command, and the execution time is reduced from 38.35s sec to 35.06 sec. ref. evanphx/kpeg#43
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 9, 2021
I compared the results between the latest release of kpeg gem (1.1.0) and HEAD of kpeg gem with `time` command, and the execution time is reduced from 38.35s sec to 35.06 sec. ref. evanphx/kpeg#43 ruby/rdoc@682bcb48ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two essential changes:
reg.match(str, pos)instead ofreg.match(str[pos..-1])\Ginstead of\AThis changes will improve the performance of the generated parser.
This will reduce a few seconds of Ruby's "make install" process
because kpeg is used to generate the markdown parser of RDoc.
This PR includes the change of #42.