Fixing error on npm run ios-sim & npm run android-sim #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evanshortiss FYI |
| @@ -11,8 +11,8 @@ | |||
| "compile": "tsc && npm run bundle-js && npm run vendor-js", | |||
| "bundle-js": "browserify -e src/index.js -o www/bundle.js --no-bundle-external --debug", | |||
| "vendor-js": "browserify -o www/vendor.js -r fh-js-sdk -r fastclick -r react-dom -r react", | |||
| "ios-sim": "npm run compile && cordova platform add ios ; && cordova run ios --emulator", | |||
There was a problem hiding this comment.
D'oh, my bad! One thing to note is that the ; was deliberate, I just forgot to remove the && on the ios-sim line.
The reason for this is that if the platform is already added Cordova returns an error exit code on add. The ; bypasses this since we just wanted to ensure the platform existed. Check this output:
> ts-react-hello-world@0.1.0 vendor-js workspaces/ts-react-hello-world
> browserify -o www/vendor.js -r fh-js-sdk -r fastclick -r react-dom -r react
Error: Platform ios already added.
Building project: workspaces/ts-react-hello-world/platforms/ios/RHMAP Hello World using TypeScript and React.xcworkspace
Configuration: Debug
Platform: emulator
If we use && after the cordova platform add ios it works fine initially, but any future calls will fail with Error: Platform ios already added.. The ; bypasses this.
What are your thoughts on a potnetial alternative for improving this?
| "ios-sim": "npm run compile && cordova platform add ios ; && cordova run ios --emulator", | ||
| "android-sim": "npm run compile && cordova platform add android ; cordova run android --emulator" | ||
| "ios-sim": "npm run compile && cordova platform add ios && cordova run ios --emulator", | ||
| "android-sim": "npm run compile && cordova platform add android cordova run android --emulator" |
There was a problem hiding this comment.
I think we'd need either ; or && here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a small error when running the iOS/Android simulator via
npm run ios-sim.Previous error: