Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error is we encounter an unknown enum value while decoding (JS) #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bvandenbos
Copy link

Fixes #11 and adds some missing enum tests.

In the javascript library, while decoding, Kiwi will throw an error if it encounters an field it doesn't know about. It won't, however, throw an error if it encounters an Enum value it doesn't know about. The decoded value will simply be undefined.

@kevzettler
Copy link

Code lgtm. This PR has conflicts and needs a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants