Fix circuits disabling instead of reducing demand #13768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premultiply
reviewed
May 5, 2024
There was a problem hiding this comment.
Schau mal. So müsste es meines Erachtens nach "richtiger" sein.
Es dürfen ja nur die positiven Ströme (= Bezug) berücksichtigt werden, da nur diese das LM über die Reduzierung der Stellgröße oder bzw. Abschaltung ausgleichen kann.
Negative Ströme können nicht zusätzlich durch Mehrleistungsaufnahme reduziert werden.
Das gleichen wir ja ohnehin in der normalen Regelung im PV-Modus aus.
| @@ -176,15 +177,15 @@ func (c *Circuit) updateLoadpoints(loadpoints []api.CircuitLoad) { | |||
| func (c *Circuit) updateMeters() error { | |||
| if f, err := c.meter.CurrentPower(); err == nil { | |||
| // TODO handle negative powers | |||
| c.power = f | |||
| c.power = math.Abs(f) | |||
| } else { | ||
| return fmt.Errorf("circuit power: %w", err) | ||
| } | ||
|
|
||
| if phaseMeter, ok := c.meter.(api.PhaseCurrents); ok { | ||
| if l1, l2, l3, err := phaseMeter.Currents(); err == nil { | ||
| // TODO handle negative currents | ||
| c.current = max(l1, l2, l3) | ||
| c.current = max(math.Abs(l1), math.Abs(l2), math.Abs(l3)) |
There was a problem hiding this comment.
c.current = max(0, l1, l2, l3) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #13750