-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use escaped Query, because it will break templating. #14146
Conversation
Good catch, thank you! |
Mhmm....das führt jetzt aber u.a. bei Tasmota-URLs zum falschen Ergebnis oder? |
Sieht so aus :(. @pmec seems we need to revert this and think a little more about how to proceed? |
@Neisi where do you get these Tasmota URLs from? Could you share a log file? |
the problem is only with custom configuration
|
Reverted |
@pmec I'm not quite sure what's wrong here and how to properly fix it. Does your use case work before 81ba7dc#diff-39f5c63d71a9df557ad9cf95d2cb3d610659c681fcdc600e535add1972e970dd? |
I think i experience the same Problem with the latest update (126.6) Here is my config:
|
This comment was marked as resolved.
This comment was marked as resolved.
Issue is fixed in master |
The question here is still: how can we not escape template variables when calling this function? Should we remove this function instead and rely on fully correct config? |
While writing a custom http charger, I found that when doing templating on a url query it would be escaped and wouldn't work.
Example of what was the result:
/write/Paused=%7B%7Bif%20.enable%7D%7D0%7B%7Belse%7D%7D1%7B%7Bend%7D%7D
What should be:
/write/Paused=1