Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve auth error handling #14375

Closed
wants to merge 4 commits into from
Closed

Improve auth error handling #14375

wants to merge 4 commits into from

Conversation

naltatis
Copy link
Member

@naltatis naltatis commented Jun 14, 2024

fixes #14373

settings api now return error when not initialized

  • auth endpoints return status 500 when database isn't initialized
  • better error communication to user
    • "server error" instead of "wrong password"
    • no "create admin password" when db isn't configured

For later: introduce same behavior for SetString

@naltatis naltatis added the bug Something isn't working label Jun 14, 2024
@naltatis naltatis requested a review from andig June 14, 2024 23:08
@andig
Copy link
Member

andig commented Jun 15, 2024

no "create admin password" when db isn't configured

how could this happen?

@naltatis
Copy link
Member Author

"Configured" is wrong. I meant initialized. (Startup error)

server/db/settings/setting.go Outdated Show resolved Hide resolved
server/db/settings/setting.go Outdated Show resolved Hide resolved
server/db/settings/setting.go Outdated Show resolved Hide resolved
@andig
Copy link
Member

andig commented Jun 15, 2024

Lass mich bitte nochmal drüber nachdenken, das ist viel hin-und-her

@andig andig marked this pull request as draft June 15, 2024 18:32
@andig andig closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set password dialog appears on invalid evcc.yaml
2 participants