Fix OCPP logic #14868

premultiply · 2024-07-14T00:11:16Z

Fix and simplify enable logic (fixes OCPP - ABB TerraAC 1.24.7 - Laden startet nicht wieder nach pausieren #12728, Ocpp: Wird Laden einmal gestoppt (bspw. weil Wolke vor der Sonne), kann es nicht wieder aufgenommen werden #14348, OCPP: Vehicle connects but doesn't start charging #13858)
Reject local StartTransaction while disabled in remote mode (from Ocpp: reject unwanted local sessions #14861)
Clear last used RFID identifier on disconnect (from Ocpp: remove identifier when session stopped #14871)
Fix broken transaction hijacking and its test

… fix/ocpp-logic

charger/ocpp.go

charger/ocpp/connector_core.go

charger/ocpp.go

andig · 2024-07-15T11:54:54Z

@premultiply ich habe Bauchschmerzen. Leider den Review nicht abgeschickt. Lass uns bitte erst besprechen wie es weiter geht.

premultiply · 2024-07-15T11:58:55Z

Brauchst du nicht, da ich es selbst getestet habe.

Läuft jetzt prima.

kschaumann · 2024-07-25T10:46:00Z

Hey @premultiply und @andig,
ich habe die Änderungen hier und in den angehängten issues immer schön verfolgt und nun 0.128.4 installiert, meine config hatte ich auf ocpp umgestellt, mit den parameter "autostart: true" und "noStop: true"

Nun beim ersten ladeversuch nach diesen Umstellungen eben hat evcc zwar den Anschluss des Fahrzeugs erkannt, aber die Wallbox hat nicht angefangen zu liefern:

Jul 25 10:00:15 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:15 ----
Jul 25 10:00:15 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:15 charge power: 0W
Jul 25 10:00:15 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:15 pv power: 7962W
Jul 25 10:00:15 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:15 battery soc: 99%
Jul 25 10:00:15 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:15 battery power: 1W
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 grid meter: -6694W
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 site power: -6693W
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 0p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 charger status: B
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] INFO 2024/07/25 10:00:16 car connected
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 vehicle api refresh
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 pv timer elapse
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 pv timer inactive
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 0p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [main  ] DEBUG 2024/07/25 10:00:16 vehicle status: B (XC40 2023)
Jul 25 10:00:16 services evcc[95709]: [main  ] DEBUG 2024/07/25 10:00:16 vehicle status: A (Zoe)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] INFO 2024/07/25 10:00:16 vehicle updated: unknown -> XC40 2023
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 set charge mode: minpv
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 pv timer reset
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 pv timer inactive
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 vehicle status: B
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 vehicle soc: 62%
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 vehicle range: 250km
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 pv charge current: 9.7A = 0A + 9.7A (-6693W @ 3p)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 max charge current: 9.7A
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 charger enable
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 wake-up timer: start
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 ----
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 charge power: 0W
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 pv power: 7962W
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 battery soc: 99%
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 battery power: 1W
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 grid meter: -6694W
Jul 25 10:00:16 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:16 site power: -6693W
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 charger status: B
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:16 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:16 pv charge current: 9.7A = 0A + 9.7A (-6693W @ 3p)
Jul 25 10:00:25 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:25 ----
Jul 25 10:00:25 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:25 charge power: 0W
Jul 25 10:00:25 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:25 pv power: 8050W
Jul 25 10:00:25 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:25 battery soc: 99%
Jul 25 10:00:25 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:25 battery power: 1W
Jul 25 10:00:25 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:25 grid meter: -6739W
Jul 25 10:00:25 services evcc[95709]: [site  ] DEBUG 2024/07/25 10:00:25 site power: -6738W
Jul 25 10:00:25 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:25 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:25 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:25 charger status: B
Jul 25 10:00:25 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:25 !! active phases: 3p = min(0p measured 3p vehicle 3p physical 0p charger)
Jul 25 10:00:25 services evcc[95709]: [lp-1  ] DEBUG 2024/07/25 10:00:25 pv charge current: 9.76A = 0A + 9.76A (-6738W @ 3p

An dem Status ändert sich auch nichts, bis ich die configuration auf "pulsarplus" umgestellt und die autostart/nostop parameter auskommentiert hatte. Nun lädt er...

zwar hatte ich wieder den üblichen Fehler:

Jul 25 10:03:35 services evcc[95753]: [lp-1  ] ERROR 2024/07/25 10:03:35 charger enable: ocpp message (1826447066): ProtocolError - validation of RemoteStartTransaction failed

aber der hat irgendwie keine Folgen. Danach startet der Ladevorgang dann...

premultiply · 2024-07-25T12:09:29Z

autostart: true funktioniert natürlich nur wenn man die Wallbox mit RFID freischaltet oder eben auf "Free Vending" konfiguriert.

kschaumann · 2024-07-25T12:29:50Z

autostart: true funktioniert natürlich nur wenn man die Wallbox mit RFID freischaltet oder eben auf "Free Vending" konfiguriert.

Ok, das war bisher kein Problem. Ich habe die Kontrolle über meine PulsarPlus komplett an OCPP abgegeben. Die App bestätigt mir auch, dass die Freigabe von dort erfolgen muss.
Meine PulsarPlus kann gar kein RFID, vor evcc musste ich das über die App machen oder (wie ich es hatte) das laden wurde mit anklemmen direkt gestartet.

Ich kann aber gern nochmal prüfen, was die App sagt wenn ich das ocpp template verwende, mit dem pulsarplus template muss ich nichts via app oder an der Wallbox selbst freischalten.

premultiply · 2024-07-25T14:14:39Z

Dann ist autostart: true für dich falsch.
Dafür gibt es ja auch die Templates.

premultiply and others added 3 commits July 13, 2024 23:25

fix enable

a1ef77d

fix invalid txn hijacking

f2376bf

Ocpp: reject unwanted local sessions

9095b51

premultiply added the enhancement New feature or request label Jul 14, 2024

premultiply requested a review from andig July 14, 2024 00:11

premultiply assigned andig and premultiply Jul 14, 2024

premultiply removed the request for review from andig July 14, 2024 00:11

premultiply added 2 commits July 14, 2024 11:28

fix enable

c7ce513

fix invalid txn hijacking

85a3122

andig force-pushed the fix/ocpp-logic branch from 9095b51 to 85a3122 Compare July 14, 2024 09:28

andig mentioned this pull request Jul 14, 2024

Ocpp: simplify configuration #14870

Closed

1 task

premultiply added 3 commits July 14, 2024 22:25

Merge branch 'master' into fix/ocpp-logic

41e771d

Merge branch 'fix/ocpp-logic' of https://github.com/evcc-io/evcc into…

da741a1

… fix/ocpp-logic

fix test

972b911

premultiply requested a review from andig July 14, 2024 20:59

This was referenced Jul 14, 2024

OCPP - ABB TerraAC 1.24.7 - Laden startet nicht wieder nach pausieren #12728

Closed

Ocpp: reject unwanted local sessions #14861

Merged

premultiply merged commit 25470ac into master Jul 15, 2024
6 checks passed

premultiply deleted the fix/ocpp-logic branch July 15, 2024 11:09

andig reviewed Jul 15, 2024

View reviewed changes

charger/ocpp.go Show resolved Hide resolved

charger/ocpp.go Show resolved Hide resolved

charger/ocpp/connector_core.go Show resolved Hide resolved

charger/ocpp.go Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix OCPP logic #14868

Fix OCPP logic #14868

premultiply commented Jul 14, 2024 •

edited

Loading

andig commented Jul 15, 2024

premultiply commented Jul 15, 2024

kschaumann commented Jul 25, 2024

premultiply commented Jul 25, 2024

kschaumann commented Jul 25, 2024

premultiply commented Jul 25, 2024

Fix OCPP logic #14868

Fix OCPP logic #14868

Conversation

premultiply commented Jul 14, 2024 • edited Loading

andig commented Jul 15, 2024

premultiply commented Jul 15, 2024

kschaumann commented Jul 25, 2024

premultiply commented Jul 25, 2024

kschaumann commented Jul 25, 2024

premultiply commented Jul 25, 2024

premultiply commented Jul 14, 2024 •

edited

Loading