Fix for Issue #12 (Fails to parse Wallet Journal) *new* #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from origin
Add a temporary constructor for the Station for citadels. This will allow to see Citadel purchases in the Wallet Transaction. Name for citadel is not resolved yet. Note: should be replaced with a proper citadel system once it's available. Also, should create an interface for the station & citadel in the WalletTransaction system.
elliena-bulmer
changed the title
This was referenced Dec 1, 2016
NevarrTivianne
pushed a commit
to NevarrTivianne/evemon
that referenced
this pull request
Apr 3, 2021
…eImport Fix extra skill completed notifications when queue is fully completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to see if the the wallet transaction was done in a citadel or station. Also added a temporary constructor for the station in the meantime that a proper citadel system is done. In the wallet transaction, it'll just list as 'Citadel' but it won't skip lines when the purchase had been done in a citadel. The Wallet journal serialization is also now using a Long instead of an Int for the ID.
Ideally, we should make an interface for Citadel/Stations and use this in the WalletJournal system. Also, the citadel should probably be resolved using the CREST API, although, i haven't found the route in order to query, As soon as I find it, I'll add the proper system to resolve the information.