Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicodeDecodeError causing InvalidMessageError trying to deserialize a message when chunked #240

Closed
nickwilliams-eventbrite opened this issue Jan 31, 2020 · 0 comments
Assignees
Labels

Comments

@nickwilliams-eventbrite
Copy link
Contributor

nickwilliams-eventbrite commented Jan 31, 2020

When chunking is enabled, some large, chunked messages are causing a UnicodeDecodeError which causes an InvalidMessageError when the re-assembled chucks are deserialized by Message Pack.

Root cause analysis: We are stripping whitespace from serialized messages when extracting header information. When messages are chunked and the chunk boundary lands on a whitespace character, this causes the re-assembled message to fail to deserialize.

nickwilliams-eventbrite added a commit that referenced this issue Feb 4, 2020
[PATCH] Fix #240 - Do not strip whitespace from serialized messages
nickwilliams-eventbrite added a commit that referenced this issue Feb 4, 2020
Changelog Details:
- [PATCH] Fix #240 - Do not strip whitespace from serialized messages
nickwilliams-eventbrite added a commit that referenced this issue Feb 25, 2020
We were stripping whitespace from serialized messages when extracting header information. When messages were chunked and the chunk boundary landed on a whitespace character, this caused the re-assembled message to fail to deserialize, as described in #240. This commit resolves this issue.
nickwilliams-eventbrite added a commit that referenced this issue Feb 25, 2020
Changelog Details:
- [PATCH] Fix two bugs regarding client expansions
- [PATCH] Update documentation
- [PATCH] Fix #240 - Do not strip whitespace from serialized messages
- [PATCH] Improve error messages and use correct msgpack dependency
- [PATCH] Try to make Travis builds faster
- [PATCH] Fix #239: stub_action side_effect now supports mix of types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant