Merge branch 'develop'

eventflow · Sep 28, 2018 · 226e05e · 226e05e
2 parents 3e0c841 + af5ff8b
commit 226e05e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,4 +1,8 @@
-### New in 0.65 (not released yet)
+### New in 0.66 (not released yet)
+
+*  **Critical fix:** - fix issue where the process using EventFlow could hang using 100% CPU due to unsynchronized Dictionary access, See #541.
+
+### New in 0.65.3664 (eleased 2018-09-22)
 
 * Minor: Performance improvement of storing events for `EventFlow.PostgreSql`
 

diff --git a/Source/EventFlow.Sql/ReadModels/ReadModelSqlGenerator.cs b/Source/EventFlow.Sql/ReadModels/ReadModelSqlGenerator.cs
@@ -42,11 +42,11 @@ public class ReadModelSqlGenerator : IReadModelSqlGenerator
         private static readonly ConcurrentDictionary<Type, IReadOnlyCollection<PropertyInfo>> PropertyInfos = new ConcurrentDictionary<Type, IReadOnlyCollection<PropertyInfo>>();
         private static readonly ConcurrentDictionary<Type, string> IdentityColumns = new ConcurrentDictionary<Type, string>();
         private static readonly ConcurrentDictionary<Type, string> VersionColumns = new ConcurrentDictionary<Type, string>();
-        private readonly Dictionary<Type, string> _insertSqls = new Dictionary<Type, string>();
-        private readonly Dictionary<Type, string> _purgeSqls = new Dictionary<Type, string>();
-        private readonly Dictionary<Type, string> _deleteSqls = new Dictionary<Type, string>();
-        private readonly Dictionary<Type, string> _selectSqls = new Dictionary<Type, string>();
-        private readonly Dictionary<Type, string> _updateSqls = new Dictionary<Type, string>();
+        private readonly ConcurrentDictionary<Type, string> _insertSqls = new ConcurrentDictionary<Type, string>();
+        private readonly ConcurrentDictionary<Type, string> _purgeSqls = new ConcurrentDictionary<Type, string>();
+        private readonly ConcurrentDictionary<Type, string> _deleteSqls = new ConcurrentDictionary<Type, string>();
+        private readonly ConcurrentDictionary<Type, string> _selectSqls = new ConcurrentDictionary<Type, string>();
+        private readonly ConcurrentDictionary<Type, string> _updateSqls = new ConcurrentDictionary<Type, string>();
 
         public ReadModelSqlGenerator()
         {

diff --git a/appveyor.yml b/appveyor.yml
@@ -1,7 +1,7 @@
 init:
   - git config --global core.autocrlf input
 
-version: 0.65.{build}
+version: 0.66.{build}
 
 skip_tags: true