green: subprocess: Popen.wait accepts new timeout kwarg
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I wrote at https://bitbucket.org/eventlet/eventlet/pull-request/30/add-dummy-timeout-parameter-to this patch resolves the issue described at https://bitbucket.org/eventlet/eventlet/issue/89/add-a-timeout-argument-to-subprocesspopen |
|
Thanks for doing this. It will really help those running OpenStack on RHEL. |
|
Merged. 0.13 will be released soon with this patch included. |
|
Thanks for merging this. I'm anxious to get an eventlet that works on RHEL in pypi- I've had to manually patch mine. Will 0.13 come out this week? |
|
Jay, I can't promise any dates. It may be this week. How do RHEL guys look at building packages from particular git or mercurial revision? Pypi releases do not contain anything different, I can guarantee that. |
|
RHEL/EPEL packages have had a simple fix for this for a long time. The problem is with people who install eventlet directly from pypi ... that's where OpenStack's developer and CI infrastructure installs from, for example. |
Thingee
pushed a commit
to Thingee/cinder
that referenced
this pull request
Oct 31, 2013
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
openstack-gerrit
pushed a commit
to openstack/keystone
that referenced
this pull request
Nov 22, 2013
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gory details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Nov 22, 2013
Project: openstack/keystone 01347d04cc1d7a4cfacb628333e721c7c4f6dd1a null Remove obsolete redhat-eventlet.patch See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gory details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
citrix-openstack-build
pushed a commit
to citrix-openstack-build/ironic
that referenced
this pull request
Dec 5, 2013
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
n0ano
pushed a commit
to n0ano/gantt
that referenced
this pull request
Dec 11, 2013
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
jistr
pushed a commit
to jistr/tuskar
that referenced
this pull request
Feb 27, 2014
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
Closed
openstack-gerrit
pushed a commit
to openstack/networking-odl
that referenced
this pull request
Dec 12, 2014
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
fawadkhaliq
pushed a commit
to fawadkhaliq/networking-plumgrid
that referenced
this pull request
Jan 2, 2015
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
yamt
pushed a commit
to yamt/networking-ofagent-old3
that referenced
this pull request
Jan 20, 2015
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
inc0
pushed a commit
to inc0/oslo.versionedobject
that referenced
this pull request
Jan 28, 2015
The gorey details for why this exists is in the commit message for commit 3c132c0. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
Tehsmash
pushed a commit
to Tehsmash/networking-cisco
that referenced
this pull request
Jan 29, 2015
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gorey details on why this exists. As of this fix: eventlet/eventlet#34 which was released in eventlet 0.13, we no longer need the patch. This has now been removed from oslo-incubator, so this is really just syncing that removal. Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in Python 3.3 http://docs.python.org/3.3/library/subprocess.html#subprocess.Popen.wait
https://bitbucket.org/eventlet/eventlet/issue/89/add-a-timeout-argument-to-subprocesspopen
https://bitbucket.org/eventlet/eventlet/pull-request/30